Repository navigation
Fix alternate row colors going out of order - #451
Merged
Merged
Conversation
A recycled row has no TableView while its content changes, so the alternate-color pass never restyled it; apply them once the row is prepared. Also refresh realized rows when an item is inserted or removed, since their index shifts without their containers being prepared again. Coalesce the dispatched pass. Fixes #440 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternate row colors could end up in the wrong order after scrolling back and forth or changing the items, so two rows of the same shade appeared next to each other.
There were two causes, both in
TableView.cs:TableViewwhile its content changes, so the existing alternate-color pass skipped it and it kept the shade of its previous index. Colors are now applied inPrepareContainerForItemOverride, right afterTableViewis set.Items.VectorChangedhandler refreshes realized rows onItemInserted/ItemRemoved, and only when an alternate brush is set.EnsureAlternateRowColorsnow coalesces its dispatched pass so a burst of changes enqueues it once. The fix does not depend on this, so it can be dropped if you prefer a smaller diff.Related Issue
Fixes #440
Type of Change
Checklist
mainbranchScreenshots / Recordings
N/A
Additional Notes
tests/TableViewAlternateRowColorsTests.cs(5 UI tests): initial rows, scrolling back and forth, collection reset, removing/inserting items above visible rows, and clearing the alternate brushes.Items.VectorChanged, whichTableViewHeaderRowalready uses on all platforms.