T7915: Use alert exn attribute for audit of uncaught exceptions at compile time #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This adds explicit compiler alerts to track exceptions within vyos1x-config and its use in vyconf and libvyosconfig.
The benefit of this "poor-man's" static analysis is a careful audit of all raised exceptions in any use of the library.
The downside is mildly unpleasant annotations and comments within the code, which will remain temporarily to provide (1) compiler warnings for any additions in vyos1x-config/vycon/libvyosconfig (2) comments describing the exception handling. These will eventually be subsumed by consistent handling using the above as a guide.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyconf#33
vyos/vyos-1x#4814
Checklist: