Skip to content

Conversation

@jestabro
Copy link
Contributor

@jestabro jestabro commented Oct 28, 2025

Change Summary

NOTE: this requires vyos/vyos1x-config#54

Track exn alerts added to vyos1x-config to catch all raised exceptions.
The main result, as expected, are a few critical changes in session.ml, to avoid uncaught exceptions leading to fatal errors, and the reassurance that all such are traced. As mentioned in the companion PR for vyos1x-config, this will inform subsequent additions to vyconf.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe): compiler driven exception audit

Related Task(s)

Related PR(s)

vyos/vyos1x-config#54
vyos/vyos-1x#4814

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

The cstore adapter (T6718) was a hybrid vyconf-legacy adapter used for a
transitional period. As it is no longer needed, remove unused code.
@dmbaturin dmbaturin merged commit 591dd5e into vyos:current Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants