Skip to content

fix(runtime-vapor): the effect being collected in the wrong scope #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Jevon617
Copy link
Contributor

@Jevon617 Jevon617 commented Apr 2, 2024

See this, delete input box content, msg.length === 3 not updated, because the constructor of ReactiveEffect is run before scope.on.

…ect is run to avoid effct being collected in the wrong scope
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit c449039
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/660bd3ca19fed6000847fb40
😎 Deploy Preview https://deploy-preview-173--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit c449039
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/660bd3ca06000e0007eec014
😎 Deploy Preview https://deploy-preview-173--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 2, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 49 kB 16.7 kB 15.1 kB
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 42 kB (-6 B) 15.6 kB 14.3 kB (-1 B)
vue-vapor.global.prod.js 88.5 kB (-6 B) 30.9 kB (+1 B) 28 kB
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 42.3 kB (-6 B) 15.7 kB (-1 B) 14.4 kB (+3 B)
overall 68.5 kB 26.1 kB 23.6 kB

@Jevon617 Jevon617 closed this Apr 2, 2024
@LittleSound
Copy link
Member

Fixed in #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants