fix: scope. on should be run before the constructor of ReactiveEffect is run to avoid effct being collected in the wrong scope

Jevon617 · Jevon617 · commit c449039bc764 · 2024-04-02T17:26:37.000+08:00
diff --git a/packages/runtime-vapor/src/renderEffect.ts b/packages/runtime-vapor/src/renderEffect.ts
@@ -43,9 +43,8 @@ export function renderEffect(cb: () => void) {
       effect.run()
     }
   }
-
+  const reset = instance && setCurrentInstance(instance)
   effect = new ReactiveEffect(() => {
-    const reset = instance && setCurrentInstance(instance)
     callWithAsyncErrorHandling(cb, instance, VaporErrorCodes.RENDER_FUNCTION)
     reset?.()
   })

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,8 @@ export function renderEffect(cb: () => void) {`
`43`	`43`	`effect.run()`
`44`	`44`	`}`
`45`	`45`	`}`
`46`		`-`
	`46`	`+ const reset = instance && setCurrentInstance(instance)`
`47`	`47`	`effect = new ReactiveEffect(() => {`
`48`		`- const reset = instance && setCurrentInstance(instance)`
`49`	`48`	`callWithAsyncErrorHandling(cb, instance, VaporErrorCodes.RENDER_FUNCTION)`
`50`	`49`	`reset?.()`
`51`	`50`	`})`