-
-
Notifications
You must be signed in to change notification settings - Fork 149
vue-template-compiler as a peer dependency #126
Conversation
`vue-template-compiler` is now a peer dependency instead of a direct dependency. This allows the user to pin `vue-template-compiler` to a specific version instead of relying on the implicit upgrades from a semver caret range. Without this change, updating Vue.js to version 2.4.2 can result in errors like this: Vue packages version mismatch: - vue@2.4.2 - vue-template-compiler@2.4.1 This may cause things to work incorrectly. Make sure to use the same version for both. If you are using vue-loader@>=10.0, simply update vue-template-compiler. If you are using vue-loader@<10.0 or vueify, re-installing vue-loader/vueify should bump vue-template-compiler to the latest. This was first reported in [vue-loader](vuejs/vue-loader#470) and later [fixed in version 10.0.0](https://gist.github.com/yyx990803/faebe22e8763f5b17572b35ed96f52fe#vue-loader1000). There is also [an open issue on vueify](vuejs/vueify#159) but it's not currently fixed.
Peer dependencies are deprecated from npm v3.x |
According to the npm 3.0.0 release doc, peerDependencies no longer cause anything to be implicitly installed but the notion of peer dependencies is still there and clearly not deprecated.
Could this PR be reopened as I still get errors when upgrading to Vue 2.4.3 this time ? |
Please check for failing tests. |
This is needed so that the tests work as expected
Tests now work when run locally but they fail on Circle CI and I don't really know why (this doesn't seem to be related to this PR)... Can you have a look and see what's wrong with Circle CI ? |
Thanks ✌️ |
I just noticed that you reverted the changes in 42082ff (vue-template-compiler is now a dependency instead of a peerDependency). |
That was a fix failing build on CI. |
I'll patch it today. , |
Ok thanks ! |
vue-template-compiler
is now a peer dependency instead of a direct dependency.This allows the user to pin
vue-template-compiler
to a specific version instead of relying on the implicit upgrades from a semver caret range.Without this change, updating Vue.js to version 2.4.2 can result in
errors like this:
Vue packages version mismatch:
This may cause things to work incorrectly. Make sure to use the same version for both.
If you are using vue-loader@>=10.0, simply update vue-template-compiler.
If you are using vue-loader@<10.0 or vueify, re-installing vue-loader/vueify should bump vue-template-compiler to the latest.
This was first reported in vue-loader and later fixed in version 10.0.0.
There is also an open issue on vueify but it's not currently fixed.