Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Commit 5ebe340

Browse files
Olivier Ligotznck
Olivier Ligot
authored andcommitted
vue-template-compiler as a peer dependency (#126)
* vue-template-compiler as a peer dependency `vue-template-compiler` is now a peer dependency instead of a direct dependency. This allows the user to pin `vue-template-compiler` to a specific version instead of relying on the implicit upgrades from a semver caret range. Without this change, updating Vue.js to version 2.4.2 can result in errors like this: Vue packages version mismatch: - vue@2.4.2 - vue-template-compiler@2.4.1 This may cause things to work incorrectly. Make sure to use the same version for both. If you are using vue-loader@>=10.0, simply update vue-template-compiler. If you are using vue-loader@<10.0 or vueify, re-installing vue-loader/vueify should bump vue-template-compiler to the latest. This was first reported in [vue-loader](vuejs/vue-loader#470) and later [fixed in version 10.0.0](https://gist.github.com/yyx990803/faebe22e8763f5b17572b35ed96f52fe#vue-loader1000). There is also [an open issue on vueify](vuejs/vueify#159) but it's not currently fixed. * Install vue-template-compiler as a dev dependency This is needed so that the tests work as expected * Don't point to internal npm registry * chore: remove unnecessary log statement * fix: use any vue-template-compiler version which is >= 2.0 * chore: remove CHANGELOG.md; using release notes for change log. [ci skip] [skip ci]
1 parent ea1459a commit 5ebe340

File tree

4 files changed

+5
-29
lines changed

4 files changed

+5
-29
lines changed

CHANGELOG.md

Lines changed: 0 additions & 23 deletions
This file was deleted.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
"posthtml-attrs-parser": "^0.1.1",
5252
"rollup-pluginutils": "^2.0.1",
5353
"typescript": "^2.4.1",
54-
"vue-template-compiler": "*",
5554
"vue-template-es2015-compiler": "^1.5.0",
5655
"vue-template-validator": "^1.1.5"
5756
},
@@ -75,7 +74,8 @@
7574
"rollup-plugin-buble": "^0.15.0",
7675
"rollup-plugin-css-only": "^0.2.0",
7776
"rollup-plugin-replace": "^1.1.1",
78-
"uglify-js": "^2.7.5"
77+
"uglify-js": "^2.7.5",
78+
"vue-template-compiler": ">=2.0"
7979
},
8080
"optionalDependencies": {
8181
"coffee-script": "^1.12.4",

src/script/coffee.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export default function (script) {
55
coffee.compile(script.code, { bare: true }, (status, output) => {
66
if (status === 0) {
77
script.code = output.replace(/^\/\/ Generated by CoffeeScript [\d]+.[\d]+.[\d]+/i, '')
8-
console.log(script.code)
98

109
resolve(script)
1110
} else {

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3437,9 +3437,9 @@ void-elements@^2.0.1:
34373437
version "2.0.1"
34383438
resolved "https://registry.yarnpkg.com/void-elements/-/void-elements-2.0.1.tgz#c066afb582bb1cb4128d60ea92392e94d5e9dbec"
34393439

3440-
vue-template-compiler@*:
3441-
version "2.2.1"
3442-
resolved "https://registry.yarnpkg.com/vue-template-compiler/-/vue-template-compiler-2.2.1.tgz#ca5e43db50dc6e761e3c1296313de33091783511"
3440+
vue-template-compiler@>=2.0:
3441+
version "2.4.4"
3442+
resolved "https://registry.yarnpkg.com/vue-template-compiler/-/vue-template-compiler-2.4.4.tgz#2cde3b704124985c27d50b5387c9691ba515fb57"
34433443
dependencies:
34443444
de-indent "^1.0.2"
34453445
he "^1.1.0"

0 commit comments

Comments
 (0)