Skip to content

Conversation

@Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Jan 9, 2024

@netlify
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 40bfc0c
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/65afc7f561fae10007caa86d

@netlify
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 40bfc0c
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/65afc7f516bad00008f3ee03
😎 Deploy Preview https://deploy-preview-2549--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebbb02f) 89.53% compared to head (f6bd586) 89.53%.
Report is 3 commits behind head on v2.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #2549   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          11       11           
  Lines        2875     2875           
  Branches      232      232           
=======================================
  Hits         2574     2574           
  Misses        285      285           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awxiaoxian2020
Copy link
Contributor

vitepress rc36 released 17 hours ago, should we upgrade to rc36?

@Jinjiang
Copy link
Member Author

Jinjiang commented Jan 9, 2024

vitepress rc36 released 17 hours ago, should we upgrade to rc36?

I upgraded to rc35 just because it supports rtl direction from that version. For other versions I personally don't mind that. However, I think it's not necessary and it could be a separated PR.

@Jinjiang
Copy link
Member Author

@posva would you mind taking a look at this failing test, please? Since I think I didn't change anything related to this test but it failed after my commits. I also ran the same test locally and it succeeded. So I have no idea what is going on.

(and the rest of this PR is ready to review)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants