-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: setup translation infra #2549
Conversation
✅ Deploy Preview for pinia-playground canceled.
|
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #2549 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 11 11
Lines 2875 2875
Branches 232 232
=======================================
Hits 2574 2574
Misses 285 285
Partials 16 16 ☔ View full report in Codecov by Sentry. |
vitepress rc36 released 17 hours ago, should we upgrade to rc36? |
I upgraded to rc35 just because it supports rtl direction from that version. For other versions I personally don't mind that. However, I think it's not necessary and it could be a separated PR. |
@posva would you mind taking a look at this failing test, please? Since I think I didn't change anything related to this test but it failed after my commits. I also ran the same test locally and it succeeded. So I have no idea what is going on. (and the rest of this PR is ready to review) Thanks. |
2 script filesvitepress-translation-helper for comparing translation checkpoints and generating translation info (same as refactor: replace translation scripts and ui with vitepress-translation-helper router#2109)rc35rc36