chore: fix typecheck and run it in CI

Backported from vitejs/vite-ecosystem-ci#261
vuejs · Jun 13, 2024 · f322ef4 · f322ef4
1 parent b4cd264
commit f322ef4
Show file tree

Hide file tree

Showing 25 changed files with 53 additions and 46 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,6 +29,8 @@ jobs:
         run: pnpm format
       - name: lint
         run: pnpm run lint
+      - name: typecheck
+        run: pnpm run typecheck
       - name: audit
         if: (${{ success() }} || ${{ failure() }})
         run: pnpm audit

diff --git a/discord-webhook.ts b/discord-webhook.ts
@@ -1,5 +1,9 @@
 import fetch from 'node-fetch'
-import { getPermanentRef, setupEnvironment, teardownEnvironment } from './utils'
+import {
+	getPermanentRef,
+	setupEnvironment,
+	teardownEnvironment,
+} from './utils.ts'
 
 type RefType = 'branch' | 'tag' | 'commit' | 'release'
 type Status = 'success' | 'failure' | 'cancelled'

diff --git a/ecosystem-ci.ts b/ecosystem-ci.ts
@@ -11,8 +11,8 @@ import {
 	bisectVue,
 	parseVueMajor,
 	parseMajorVersion,
-} from './utils'
-import { CommandOptions, RunOptions } from './types'
+} from './utils.ts'
+import { CommandOptions, RunOptions } from './types.ts'
 
 const cli = cac()
 cli

diff --git a/package.json b/package.json
@@ -11,6 +11,7 @@
     "lint:fix": "pnpm lint --fix",
     "format": "prettier --ignore-path .gitignore --check .",
     "format:fix": "pnpm format --write",
+    "typecheck": "tsc",
     "test:self": "tsx ecosystem-ci.ts _selftest",
     "test": "tsx ecosystem-ci.ts",
     "clean": "rimraf .verdaccio-cache/.local workspace && pnpm store prune",

diff --git a/registry.ts b/registry.ts
@@ -12,11 +12,9 @@ export const REGISTRY_ADDRESS = `http://localhost:${LOCAL_REGISTRY_PORT}/`
 export async function startRegistry() {
 	// It's not ideal to repeat this config option here,
 	// luckily, `self_path` would no longer be required in verdaccio 6
-	// @ts-expect-error import.meta
 	const cache = fileURLToPath(new URL('./.verdaccio-cache', import.meta.url))
 	const config = {
 		...parseConfigFile(
-			// @ts-expect-error import.meta
 			fileURLToPath(new URL('./verdaccio.yaml', import.meta.url)),
 		),
 		self_path: cache,

diff --git a/tests/_selftest.ts b/tests/_selftest.ts
@@ -1,6 +1,6 @@
 import path from 'node:path'
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/language-tools.ts b/tests/language-tools.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/naive-ui.ts b/tests/naive-ui.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/nuxt.ts b/tests/nuxt.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/pinia.ts b/tests/pinia.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/primevue.ts b/tests/primevue.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/quasar.ts b/tests/quasar.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/radix-vue.ts b/tests/radix-vue.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/router.ts b/tests/router.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/test-utils.ts b/tests/test-utils.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vant.ts b/tests/vant.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vite-plugin-vue.ts b/tests/vite-plugin-vue.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vitepress.ts b/tests/vitepress.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vue-i18n.ts b/tests/vue-i18n.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vue-macros.ts b/tests/vue-macros.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vue-simple-compiler.ts b/tests/vue-simple-compiler.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vuetify.ts b/tests/vuetify.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tests/vueuse.ts b/tests/vueuse.ts
@@ -1,5 +1,5 @@
-import { runInRepo } from '../utils'
-import { RunOptions } from '../types'
+import { runInRepo } from '../utils.ts'
+import { RunOptions } from '../types.ts'
 
 export async function test(options: RunOptions) {
 	await runInRepo({

diff --git a/tsconfig.json b/tsconfig.json
@@ -4,7 +4,8 @@
 	"compilerOptions": {
 		"target": "esnext",
 		"module": "NodeNext",
-		"moduleResolution": "node",
+		"moduleResolution": "NodeNext",
+		"allowImportingTsExtensions": true,
 		"strict": true,
 		"declaration": true,
 		"noImplicitOverride": true,
@@ -14,6 +15,8 @@
 		"allowSyntheticDefaultImports": true,
 		"lib": ["esnext"],
 		"sourceMap": true,
-		"typeRoots": ["./typings/node_modules/@types"]
+		"typeRoots": ["./typings/node_modules/@types"],
+		"noEmit": true,
+		"skipLibCheck": true
 	}
 }
diff --git a/utils.ts b/utils.ts
@@ -9,8 +9,8 @@ import {
 	RepoOptions,
 	RunOptions,
 	Task,
-} from './types'
-import { REGISTRY_ADDRESS, startRegistry } from './registry'
+} from './types.ts'
+import { REGISTRY_ADDRESS, startRegistry } from './registry.ts'
 //eslint-disable-next-line n/no-unpublished-import
 import { detect, AGENTS, Agent, getCommand } from '@antfu/ni'
 import actionsCore from '@actions/core'
@@ -87,7 +87,6 @@ let app: any
 export async function setupEnvironment(): Promise<EnvironmentData> {
 	app = await startRegistry()
 
-	// @ts-expect-error import.meta
 	const root = dirnameFrom(import.meta.url)
 	const workspace = path.resolve(root, 'workspace')
 	vuePath = path.resolve(workspace, 'core')