fix: fix typecheck and run it in CI #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Nov 2, 2023
| "compilerOptions": { | ||
| "target": "esnext", | ||
| "module": "nodenext", | ||
| "moduleResolution": "node", | ||
| "moduleResolution": "nodenext", |
There was a problem hiding this comment.
tsconfig.json:7:23 - error TS5109: Option 'moduleResolution' must be set to 'NodeNext' (or left unspecified) when option 'module' is set to 'NodeNext'.
7 "moduleResolution": "node",
~~~~~~
This error was happening. Therefore I changed to nodenext and also added "allowImportingTsExtensions": true and "noEmit": true.
danielroe
pushed a commit
to nuxt/ecosystem-ci
that referenced
this pull request
Jan 3, 2024
haoqunjiang
added a commit
to vuejs/ecosystem-ci
that referenced
this pull request
Jun 13, 2024
Backported from vitejs/vite-ecosystem-ci#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
pnpm tsc --noEmitshowed many errors. This PR fixes that and also addpnpm typecheckand runs that in CI.