Skip to content

Fixes repeatedly throwing incorrect errors when queries hits cache immediately after an Apollo error #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Fixes repeatedly throwing incorrect errors when queries hits cache immediately after an Apollo error #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/smart-query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,19 +70,13 @@ export default class SmartQuery extends SmartApollo {
}

executeApollo (variables) {
if (this.observer) {
// Update variables
// Don't use setVariables directly or it will ignore cache
this.observer.setOptions(this.generateApolloOptions(variables))
} else {
if (this.sub) {
this.sub.unsubscribe()
}

// Create observer
this.observer = this.vm.$apollo.watchQuery(this.generateApolloOptions(variables))
if (this.sub) {
this.sub.unsubscribe()
}

// Create observer
this.observer = this.vm.$apollo.watchQuery(this.generateApolloOptions(variables))

this.startQuerySubscription()

if (this.options.fetchPolicy !== 'no-cache') {
Expand Down