Fixes repeatedly throwing incorrect errors when queries hits cache immediately after an Apollo error #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v3.0.0-beta.14, query subscription is restarted after an error. This works well in most cases, but if an error occurs and subsequent queries hit the cache, the same error is thrown repeatedly instead of the correct value being fetched from the cache.
To demonstrate the behavior, let's say we have a resolver which accepts two arguments - value, and do_throw. if do_throw is false the resolver simply echoes value and if do_throw is true it throws an error with value.
Pseudocode:
The problem is likely to be an upstream issue in Apollo, nevertheless, it can be resolved easily by not reusing SmartQuery.observer and creating an observer each time executeApollo() is called. (Or at least after an error has occurred.)