RabbitMQ 3.7.9+ list compatibility and provider cleanup #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Jan 15, 2019
There was a problem hiding this comment.
This looks pretty clean to me, and while using the API or using json out where supported would be better, this seems like a good incremental fix. Going to flag a couple other folks for review since this is a pretty big change. Can you also squash, either down to one commit or into logical commits?
wyardley
approved these changes
Jan 15, 2019
bastelfreak
approved these changes
Jan 15, 2019
alexjfisher
approved these changes
Jan 15, 2019
| end | ||
|
|
||
| # Retry the given code block 'count' retries or until the | ||
| # command suceeeds. Use 'step' delay between retries. |
|
Thanks for the contribution @JayH5 |
|
Thanks!
Yeah that's fine. Would've done that myself but just pushed this PR as I was ending my work day. |
|
Great! We are trying to cut a release of this soon. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
* RabbitMQ 3.7.9+ list compatibility and provider cleanup (voxpupuli#759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is an alternative attempt at fixing
rabbitmqctl list_{x}commands with RabbitMQ 3.7.9+. #751 was also an attempt. This PR takes a different approach by adding a class method in the "parent" provider class for all the providers. This method provides a consistent way to runrabbitmqctl list_operations in all provider classes.This PR also cleans up the process of finding RabbitMQ CLI binaries: all providers now share the same command methods. It also adds caching to the RabbitMQ version value.
This Pull Request (PR) fixes the following issues
Fixes #740