Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runs with RabbitMQ >= 3.7.9 #751

Closed
wants to merge 1 commit into from

Conversation

alexconrey
Copy link

@alexconrey alexconrey commented Dec 14, 2018

Pull Request (PR) description

RabbitMQ >= 3.7.9 rabbitmqctl exec produces table/column header output which does not parse cleanly with the current way that the module is setup. This implements a version check, which will update the command in the event a version with the --no-table-headers flag should be used.

This Pull Request (PR) fixes the following issues

Fixes #740

Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec tests still will need to be adjusted, and there are some rubocop errors as well

@bastelfreak
Copy link
Member

Hi @alexconrey, thanks for the PR. Can you please take a look at the failed spec tests?

@gokuatkai
Copy link

gokuatkai commented Jan 8, 2019

puppet: 4.7.1
puppet agent: 1.7.2
ruby (embedded): ruby 2.1.9p490
rabbitmq module version: 8.2.0

The variable @format_table_headers works inside the parent provider class Puppet::Provider::Rabbitmqctl. But when it runs the rabbitmq_user provider the variable is empty, would you know why?
I checked the change log of puppet versions and I did not see any fix regarding any scope for variable between inherited providers class.

@bastelfreak
Copy link
Member

We need to do a modulesync here and afterwards rebase this branch.

@wyardley
Copy link
Contributor

Hi @alexconrey: Looks like #759 should resolve this once approved / merged.

@wyardley wyardley closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmqctl 'broken' in 3.7.9
4 participants