Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't manage installation of git #502

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Don't manage installation of git #502

merged 1 commit into from
Oct 27, 2019

Conversation

Andor
Copy link
Contributor

@Andor Andor commented Oct 23, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Copy of #435

@bastelfreak
Copy link
Member

thanks for the PR!

@bastelfreak bastelfreak merged commit 524be4a into voxpupuli:master Oct 27, 2019
@alexjfisher
Copy link
Member

I agree that this didn't belong in this module. However, I think this should have been marked as breaking and documented in the README.

@alexjfisher alexjfisher changed the title remove git dependency from r10k::install::puppet_gem Don't manage installation of git Oct 28, 2019
@alexjfisher
Copy link
Member

The better option might have been to introduce a manage_git parameter.

@dhoppe dhoppe mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants