remove ::git dependency from r10k::install::puppet_gem

[Andor]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[bastelfreak]

@rnelson0 any ideas if we can safely remove the dependency? I think it shouldn't be an issue?

[Andor]

Doesn't looks like we need it from the beginning.

[rnelson0]

While the puppet code does not need git, we expect a git binary to be there. Which is what the git module does. I think it should be left.

[rnelson0]

@Andor You didn't specify what the issue is that is being resolved, can you explain why you think this should not be present?

[Andor]

@rnelson0 sorry for late response. git class isn't used anywhere in this module and can be removed. It is just not needed.

[witchbutter]

I agree this should be removed. The git package is likely to be defined at a higher level when using a control repository. It would be easier to have a fact that fails the application of the module if there is no git binary, or at least a switch parameter to remove the git requirement.

[siebrand]

I ran into the same issue. The issue is that the git module is no longer maintained. It installs using package[1], and not ensure_packages, and this leads to obvious and unexpected issues. Removing this dependency would be a minor change here, as well as a major improvement.

[1] https://github.com/Aethylred/puppet-git/blob/master/manifests/init.pp#L53

[pccibot]

Dear @Andor, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[pccibot]

Dear @Andor, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks