Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap is_pe fact in fact() method to fail safely if it isn't present #438

Merged
merged 2 commits into from
Jul 5, 2018
Merged

wrap is_pe fact in fact() method to fail safely if it isn't present #438

merged 2 commits into from
Jul 5, 2018

Commits on Jul 5, 2018

  1. test against master branch of stdlib

    @bastelfreak
    bastelfreak committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    89b898c View commit details
    Browse the repository at this point in the history

  2. wrap is_pe fact in fact() method to fail safely 

    the fact() methods returns the value of a fact if it is present,
otherwise undef. This allows us to safely jump into the else block. And
that allows us to use this module as a dependency without the need to
always mock the is_pe fact.
    @bastelfreak
    bastelfreak committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    57fb516 View commit details
    Browse the repository at this point in the history