Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap is_pe fact in fact() method to fail safely if it isn't present #438

Merged
merged 2 commits into from
Jul 5, 2018
Merged

wrap is_pe fact in fact() method to fail safely if it isn't present #438

merged 2 commits into from
Jul 5, 2018

Conversation

bastelfreak
Copy link
Member

From the commit message:

the fact() methods returns the value of a fact if it is present,
otherwise undef. This allows us to safely jump into the else block. And
that allows us to use this module as a dependency without the need to
always mock the is_pe fact.

@bastelfreak
test against master branch of stdlib
89b898c
@bastelfreak
wrap is_pe fact in fact() method to fail safely
57fb516 
the fact() methods returns the value of a fact if it is present,
otherwise undef. This allows us to safely jump into the else block. And
that allows us to use this module as a dependency without the need to
always mock the is_pe fact.
@bastelfreak bastelfreak added the enhancement New feature or request label Jul 5, 2018
@bastelfreak bastelfreak merged commit 0dfc213 into voxpupuli:master Jul 5, 2018
@bastelfreak bastelfreak deleted the is_pe branch July 5, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhollinger dhollinger dhollinger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @dhollinger