BREAKING: Fix webhook installation by pinning sinatra gem #366
Conversation
This code doesn't do anything. rack is a dependency of sinatra which the module is already installing.
| portage: | ||
| repo: "git://github.com/gentoo/puppet-portage.git" | ||
| repo: "https://github.com/gentoo/puppet-portage.git" |
There was a problem hiding this comment.
oops. I didn't actually mean to commit changes to this file. I can remove them, but then again, they are very useful to those trying to test behind a firewall with only an http/https proxy available for Internet access.
There was a problem hiding this comment.
That's a great catch, I have lost so much time to using git:// where it doesn't work, but never the other way around.
alexjfisher
force-pushed
the
pin_sinatra
branch
2 times, most recently
from
f9aa997
to
2a4ed16
Compare
| portage: | ||
| repo: "git://github.com/gentoo/puppet-portage.git" | ||
| repo: "https://github.com/gentoo/puppet-portage.git" |
There was a problem hiding this comment.
That's a great catch, I have lost so much time to using git:// where it doesn't work, but never the other way around.
| if !defined(Package['rack']) { | ||
| package { 'rack': | ||
| ensure => installed, | ||
| ensure => $sinatra_version, |
There was a problem hiding this comment.
As ~> 1.0 may not work for all possible providers, though it does work with the default provider, can you add some verbiage about it this param in either this file's header as comments, or in the README?
There was a problem hiding this comment.
Ok. I can't think of any situation where it wouldn't be a gem provider and the package would still be called sinatra (and not ruby-sinatra or something), so a note in the source should be ok? I'll update it in the morning.
There was a problem hiding this comment.
Right, but installed works with all providers, whereas ~> 1.0 doesn't work with many of them. This change could be a breaking change to someone using a non-standard provider, so I think it may be helpful to promote it in the README. I'll look tomorrow to see if there's an appropriate place unless you find one first.
Sinatra 2.0.0 was released on the 7th of May 2017. It requires rack ~>
2.0 and *that* requires ruby 2.2. Puppet 4 AIO ships with ruby 2.1, so
pin sinatra to prevent errors like.
```
Error: Execution of '/opt/puppetlabs/puppet/bin/gem install --no-rdoc
--no-ri sinatra' returned 1: ERROR: Error installing sinatra:
rack requires Ruby version >= 2.2.2.
```
Fixes voxpupuli#140
dhollinger
changed the title
|
Fixes #365 |
Sinatra 2.0.0 was released on the 7th of May 2017. It requires rack ~> 2.0 and that requires ruby 2.2. Puppet 4 AIO ships with ruby 2.1, so pin sinatra to prevent errors. I've also removed the code that managed rack installation as this was redundant.