webhook gems aren't installable

[alexjfisher]

The latest version of rack isn't installable on puppet's ruby 2.1.9.
Up until now, this wasn't a problem as the sinatra gem got installed first and it had a dependency on rack ~> 1.5. (We may as well remove

puppet-r10k/manifests/webhook/package.pp

Lines 14 to 20 in 1d0c344

	if !defined(Package['rack']) {
	package { 'rack':
	ensure => installed,
	provider => $provider,
	before => Service['webhook'],
	}
	}

)

Sinatra 2.0.0 got released yesterday. It depends on the newer rack. rack ~> 2.0, so we now get

Error: Execution of '/opt/puppetlabs/puppet/bin/gem install --no-rdoc --no-ri sinatra' returned 1: ERROR:  Error installing sinatra:
        rack requires Ruby version >= 2.2.2.
Error: /Stage[main]/R10k::Webhook::Package/Package[sinatra]/ensure: change from absent to present failed: Execution of '/opt/puppetlabs/puppet/bin/gem install --no-rdoc --no-ri sinatra' returned 1: ERROR:  Error installing sinatra:
        rack requires Ruby version >= 2.2.2.

Due to the if !defined, wrapping the installation of sinatra, this is easy enough to work around in my profile. We should probably fix the issue in the module though. Is it ok to change

package { 'sinatra':
  ensure   => installed,
  provider => $provider,
  before   => Service['webhook'],
}

to

package { 'sinatra':
  ensure   => '1.4.8',
  provider => $provider,
  before   => Service['webhook'],
}

??

[rnelson0]

That should be okay, but let's parameterize it with something that defaults to '1.4.8', in case someone wants to provide a specific lower version number.

Re: L14-20, can that be removed? If that's a dependency, seems like the gem provider will install it automatically.

[alexjfisher]

When puppet gets around to 14-20 it has nothing to do since rack is already installed (as a sinatra dependency). Had this not been the case, the module would have been failing since last June (when rack 2.0 came out).