This version is not rails 6 compatible #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates v4.1.4 to v4.1.5 by correcting its gemspec to note that this version is not compatible with Rails 5.
By then updating sbn to v4.1.5, we ensure we don't/can't deploy a rails 6 branch without also updating this incompatible version.
After approval, this PR should be merged into the new
4-1-stablebranch, the result taggedv4.1.5, and not merged into master. The current sbn should then have this gem updated to4.1.5. Thev4.1.4tag should then be deleted because it incorrectly claims it is rails 6 compatible when it is not.