Compatibility with both rails 5 and 6 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiemccarthy
changed the title
ebinmore
approved these changes
Jul 26, 2022
vegantech
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first #3.
This PR updates
#callto work under either rails 5 or 6. See #2 for why rails 6 needs the new argument.I did this by explicitly testing
Rails.versionjust because we know that is what makes one work and one not. Other opinions are valid, e.g.HAML::Pluginfixed it by testing forsource.nil?. I care 2/10.After approval, this PR should be merged into
master, and the result taggedv4.2.1.We should then delete the
v4.2.0tag, which incorrectly claims it is rails 5 compatible which it is not.sbn's rails 6 branches should then be updated to bump this gem's version from
4.1.5to4.2.1.