This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
feat: Deprecate tslint and eslint all the things. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vw-bmd ready! Built with commit 2ba074a |
benadida
approved these changes
May 9, 2019
There was a problem hiding this comment.
I'm a little annoyed by the super strict commit message formatting, it is super constraining when doing development and encourages commit squashing too early.
If it's important to you, I can live with it, but let's keep an eye on the paper cuts because I've found development on BAS to be harder as a result.
|
Yes, I agree. It's a little pre-optimized. Let's discuss and fix it. |
|
I can live with it if there is no obvious easier path. |
|
I've removed commitlint and will merge this without a commit linter for now. |
|
Captured here: #338 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace tslint with eslint, stylelint, commitlint, etc.
Sync'd with BAS linting, etc.