This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Convert to use ESLint for linting TypeScript, etc. (WIP) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for vw-bmd ready! Built with commit 0304433 |
beausmith
force-pushed
the
ts-eslint-parser
branch
from
b452099 to
4506d2a
Compare
4 tasks
beausmith
force-pushed
the
ts-eslint-parser
branch
from
5e67a2e to
735412d
Compare
TypeScript ESLint Parser is deprecated: - https://eslint.org/blog/2019/01/future-typescript-eslint - bradzacher/eslint-plugin-typescript#290 Helpful articles/resources influencing this PR: - https://github.com/typescript-eslint/typescript-eslint - https://javascriptplayground.com/typescript-eslint/ - https://dev.to/robertcoopercode/using-eslint-and-prettier-in-a-typescript-project-53jb - https://github.com/Shopify/eslint-plugin-shopify
Pending issues with plugin: #199
beausmith
force-pushed
the
ts-eslint-parser
branch
from
735412d to
0304433
Compare
|
@benadida - I pushed a few more changes. Can you please re-review? 😄 |
beausmith
changed the title
beausmith
changed the title
|
Something related to this config was causing Code Helper to take up 100% CPU. Thus this PR was on hold. After a little more research, seems that it may have been related to
Trying |
beausmith
added a commit
that referenced
this pull request
Apr 16, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 17, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
beausmith
added a commit
that referenced
this pull request
Apr 23, 2019
In attempt to fix issues with high CPU usage of VS Code due to bug in @types/styled-components, I removed the node_modules folder and ran `yarn` which updated this lock file. More info: #174 (comment)
|
Solved differently in: #329 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript ESLint Parser is deprecated:
Helpful articles/resources influencing this PR: