Skip to content

Slice(ChunkedArray) canonicalizes all chunks instead of only relevant ones #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palaska wants to merge 3 commits into
base: develop
Choose a base branch
from
+17 −0
Open

Slice(ChunkedArray) canonicalizes all chunks instead of only relevant ones #6648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceed427
fix: SliceVTable should execute through the full loop in append_to_bu…
palaska Feb 23, 2026
d30b15f
lock
palaska Feb 23, 2026
b62a8e8
fix comment
palaska Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vortex-array/public-api.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3152,6 +3152,8 @@ pub type vortex_array::arrays::SliceVTable::ValidityVTable = vortex_array::array

pub type vortex_array::arrays::SliceVTable::VisitorVTable = vortex_array::arrays::SliceVTable

pub fn vortex_array::arrays::SliceVTable::append_to_builder(array: &Self::Array, builder: &mut dyn vortex_array::builders::ArrayBuilder, ctx: &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<()>

pub fn vortex_array::arrays::SliceVTable::build(dtype: &vortex_array::dtype::DType, len: usize, metadata: &vortex_array::arrays::SliceMetadata, _buffers: &[vortex_array::buffer::BufferHandle], children: &dyn vortex_array::serde::ArrayChildren) -> vortex_error::VortexResult<Self::Array>

pub fn vortex_array::arrays::SliceVTable::deserialize(_bytes: &[u8], _dtype: &vortex_array::dtype::DType, _len: usize, _buffers: &[vortex_array::buffer::BufferHandle], _session: &vortex_session::VortexSession) -> vortex_error::VortexResult<Self::Metadata>
Expand Down Expand Up @@ -16488,6 +16490,8 @@ pub type vortex_array::arrays::SliceVTable::ValidityVTable = vortex_array::array

pub type vortex_array::arrays::SliceVTable::VisitorVTable = vortex_array::arrays::SliceVTable

pub fn vortex_array::arrays::SliceVTable::append_to_builder(array: &Self::Array, builder: &mut dyn vortex_array::builders::ArrayBuilder, ctx: &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<()>

pub fn vortex_array::arrays::SliceVTable::build(dtype: &vortex_array::dtype::DType, len: usize, metadata: &vortex_array::arrays::SliceMetadata, _buffers: &[vortex_array::buffer::BufferHandle], children: &dyn vortex_array::serde::ArrayChildren) -> vortex_error::VortexResult<Self::Array>

pub fn vortex_array::arrays::SliceVTable::deserialize(_bytes: &[u8], _dtype: &vortex_array::dtype::DType, _len: usize, _buffers: &[vortex_array::buffer::BufferHandle], _session: &vortex_session::VortexSession) -> vortex_error::VortexResult<Self::Metadata>
Expand Down
13 changes: 13 additions & 0 deletions vortex-array/src/arrays/slice/vtable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ use crate::Precision;
use crate::arrays::slice::array::SliceArray;
use crate::arrays::slice::rules::PARENT_RULES;
use crate::buffer::BufferHandle;
use crate::builders::ArrayBuilder;
use crate::dtype::DType;
use crate::executor::ExecutionCtx;
use crate::scalar::Scalar;
Expand Down Expand Up @@ -108,6 +109,18 @@ impl VTable for SliceVTable {
Ok(())
}

fn append_to_builder(
array: &Self::Array,
builder: &mut dyn ArrayBuilder,
ctx: &mut ExecutionCtx,
) -> VortexResult<()> {
// Execute through the full loop so that execute_parent optimizations
// can fire before we canonicalize.
let canonical = array.to_array().execute::<Canonical>(ctx)?;
builder.extend_from_array(canonical.as_ref());
Ok(())
}

fn execute(array: &Self::Array, ctx: &mut ExecutionCtx) -> VortexResult<ArrayRef> {
// Execute the child to get canonical form, then slice it
let Some(canonical) = array.child.as_opt::<AnyCanonical>() else {
Expand Down
Loading