Slice(ChunkedArray) canonicalizes all chunks instead of only relevant ones#6648
Open
Slice(ChunkedArray) canonicalizes all chunks instead of only relevant ones#6648
Conversation
palaska
changed the title
Merging this PR will improve performance by 12.36%
Performance Changes
Comparing 
Footnotes
|
…ilder SliceVTable::execute bypasses execute_parent, so SliceExecuteAdaptor never fires on Slice(ChunkedArray) — canonicalizing all chunks instead of just the relevant ones. Signed-off-by: Baris Palaska <barispalaska@gmail.com>
palaska
changed the title
Signed-off-by: Baris Palaska <barispalaska@gmail.com>
palaska
changed the title
Contributor
|
this seems reasonable, running benchmarks to make sure there are no surprises |
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
AdamGS
approved these changes
Feb 24, 2026
Contributor
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
I think this makes perfect sense, I'm not sure there's a way to test it though
Contributor
Author
|
I noticed this was also missing at Filter as well (#6650). Holding off until we decide whether we want to do this by default (#6655) . It looks like it degrades perf a little but not sure how important that is. A wasted execute_parent call should be just a couple of vtable dispatches and a type check, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SliceVTable was using the default append_to_builder, which calls SliceVTable::execute directly. This bypasses the execution loop, so execute_parent optimizations like SliceExecuteAdaptor(ChunkedVTable) never fire.
For Slice(ChunkedArray), this means the entire chunked array gets canonicalized before slicing — instead of using find_chunk_idx to select only the relevant chunks first.