Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 16, 2026

Reverts #5952. This sort of isn't currently supported on codspeed

@AdamGS AdamGS added the changelog/chore A trivial change label Jan 16, 2026
This reverts commit 924830c.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the revert-5952-adamg/run-memory-benchmarks branch from a426c83 to be3f816 Compare January 16, 2026 15:17
@AdamGS AdamGS enabled auto-merge (squash) January 16, 2026 15:19
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

Merging this PR will degrade performance by 40.77%

⚡ 33 improved benchmarks
❌ 23 regressed benchmarks
✅ 1198 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_compare_varbinview[(10000, 2)] 215.6 µs 194.5 µs +10.84%
Simulation bench_compare_sliced_dict_primitive[(2000, 10000)] 77.2 µs 120.5 µs -35.9%
Simulation bench_compare_sliced_dict_primitive[(1000, 10000)] 66.8 µs 112.7 µs -40.77%
Simulation bench_compare_sliced_dict_primitive[(2500, 10000)] 90.6 µs 125.1 µs -27.6%
Simulation bench_compare_sliced_dict_primitive[(3333, 10000)] 102.8 µs 133 µs -22.74%
Simulation bench_compare_sliced_dict_primitive[(5000, 10000)] 125.7 µs 146.9 µs -14.44%
Simulation bench_compare_sliced_dict_varbinview[(2500, 10000)] 451 µs 394.5 µs +14.31%
Simulation bench_compare_sliced_dict_varbinview[(1000, 10000)] 218.1 µs 256.6 µs -15%
Simulation bench_compare_sliced_dict_varbinview[(10000, 10000)] 768.9 µs 503.5 µs +52.72%
Simulation bench_compare_sliced_dict_varbinview[(9999, 10000)] 769.3 µs 503.5 µs +52.77%
Simulation bench_compare_sliced_dict_varbinview[(3333, 10000)] 580 µs 488.7 µs +18.69%
Simulation bench_compare_sliced_dict_varbinview[(2000, 10000)] 374 µs 338.5 µs +10.49%
Simulation bench_compare_sliced_dict_varbinview[(20000, 10000)] 1,076 µs 698.5 µs +54.03%
Simulation bench_compare_sliced_dict_varbinview[(7500, 10000)] 748.4 µs 482.9 µs +54.97%
Simulation bench_compare_sliced_dict_varbinview[(5000, 10000)] 836.2 µs 674.9 µs +23.9%
Simulation decompress_bitpacking_early_filter[i32, 0.01] 105.2 µs 117.2 µs -10.18%
Simulation decompress_bitpacking_early_filter[i16, 0.01] 99.3 µs 111.3 µs -10.77%
Simulation decompress_bitpacking_early_filter[i32, 0.0105] 106.8 µs 119.5 µs -10.61%
Simulation decompress_bitpacking_early_filter[i16, 0.02] 123.6 µs 140.2 µs -11.88%
Simulation decompress_bitpacking_early_filter[i16, 0.0105] 100.6 µs 113.3 µs -11.16%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing revert-5952-adamg/run-memory-benchmarks (be3f816) with develop (b83535a)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS merged commit ba2339a into develop Jan 16, 2026
46 of 48 checks passed
@AdamGS AdamGS deleted the revert-5952-adamg/run-memory-benchmarks branch January 16, 2026 15:25
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.88%. Comparing base (b83535a) to head (be3f816).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

danking pushed a commit that referenced this pull request Feb 6, 2026
Reverts #5952. This sort of isn't currently supported
on codspeed

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants