Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 14, 2026

This adds less then a minute to CI and seems super useful, see results https://codspeed.io/vortex-data/vortex/branches/adamg%2Frun-memory-benchmarks

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.39%. Comparing base (29d7aa1) to head (06c13b8).
⚠️ Report is 4 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS marked this pull request as ready for review January 14, 2026 13:47
@AdamGS AdamGS added changelog/chore A trivial change and removed experiment labels Jan 14, 2026
@AdamGS AdamGS changed the title [WIP] Run codspeed memory benchmarks Run codspeed memory benchmarks Jan 14, 2026
@AdamGS AdamGS requested review from 0ax1, danking and robert3005 January 14, 2026 13:50
@AdamGS AdamGS merged commit 924830c into develop Jan 14, 2026
58 of 62 checks passed
@AdamGS AdamGS deleted the adamg/run-memory-benchmarks branch January 14, 2026 17:45
@adriencaccia
Copy link

Hey @AdamGS, glad to have using the new memory instrument 😉

However there is an issue with your current setup, at the moment all the CPU simulation benchmarks are skipped.
This is because in this PR you ran the CodSpeedHQ/action with mode: memory in the same job of the one with mode: simulation. We do not support that at the moment, we need to have different jobs for different instruments.

The fix will be to have mode: [simulation, memory] in your matrix definition and use that value in the build and run steps.

@AdamGS
Copy link
Contributor Author

AdamGS commented Jan 16, 2026

Thank you for the heads up! I'll revert this change and do it right when I have the bandwidth

AdamGS added a commit that referenced this pull request Jan 16, 2026
AdamGS added a commit that referenced this pull request Jan 16, 2026
This reverts commit 924830c.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS added a commit that referenced this pull request Jan 16, 2026
Reverts #5952. This sort of isn't currently supported
on codspeed

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@adriencaccia
Copy link

adriencaccia commented Jan 22, 2026

Thank you for the heads up! I'll revert this change and do it right when I have the bandwidth

Hey @AdamGS, we just released a new feature that supports consecutive runs, so you can re-enable memory benchmarks if you want!
Another thing, the builds for simulation and memory are the same, so you do not need to do it twice.

The following should do the trick:

      - name: Build benchmarks
        env:
          RUSTFLAGS: "-C target-feature=+avx2 -C debug-assertions=yes"
        run: cargo codspeed build ${{ matrix.features }} $(printf -- '-p %s ' ${{ matrix.packages }}) --profile bench
      - name: Run benchmarks
        uses: CodSpeedHQ/action@e736f0d2aeb36da38e9f08eca4dff7967408d154 # 4.8.2
        with:
          run: cargo codspeed run
          token: ${{ secrets.CODSPEED_TOKEN }}
          mode: "simulation"
      - name: Run memory benchmarks
        uses: CodSpeedHQ/action@e736f0d2aeb36da38e9f08eca4dff7967408d154 # 4.8.2
        with:
          run: cargo codspeed run
          token: ${{ secrets.CODSPEED_TOKEN }}
          mode: "memory"

danking pushed a commit that referenced this pull request Feb 6, 2026
This adds less then a minute to CI and seems super useful, see results
https://codspeed.io/vortex-data/vortex/branches/adamg%2Frun-memory-benchmarks

---------

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
danking pushed a commit that referenced this pull request Feb 6, 2026
Reverts #5952. This sort of isn't currently supported
on codspeed

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants