-
Notifications
You must be signed in to change notification settings - Fork 132
Run codspeed memory benchmarks #5952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @AdamGS, glad to have using the new memory instrument 😉 However there is an issue with your current setup, at the moment all the CPU simulation benchmarks are skipped. The fix will be to have |
|
Thank you for the heads up! I'll revert this change and do it right when I have the bandwidth |
This reverts commit 924830c. Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Reverts #5952. This sort of isn't currently supported on codspeed Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Hey @AdamGS, we just released a new feature that supports consecutive runs, so you can re-enable memory benchmarks if you want! The following should do the trick: - name: Build benchmarks
env:
RUSTFLAGS: "-C target-feature=+avx2 -C debug-assertions=yes"
run: cargo codspeed build ${{ matrix.features }} $(printf -- '-p %s ' ${{ matrix.packages }}) --profile bench
- name: Run benchmarks
uses: CodSpeedHQ/action@e736f0d2aeb36da38e9f08eca4dff7967408d154 # 4.8.2
with:
run: cargo codspeed run
token: ${{ secrets.CODSPEED_TOKEN }}
mode: "simulation"
- name: Run memory benchmarks
uses: CodSpeedHQ/action@e736f0d2aeb36da38e9f08eca4dff7967408d154 # 4.8.2
with:
run: cargo codspeed run
token: ${{ secrets.CODSPEED_TOKEN }}
mode: "memory" |
This adds less then a minute to CI and seems super useful, see results https://codspeed.io/vortex-data/vortex/branches/adamg%2Frun-memory-benchmarks --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Reverts #5952. This sort of isn't currently supported on codspeed Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This adds less then a minute to CI and seems super useful, see results https://codspeed.io/vortex-data/vortex/branches/adamg%2Frun-memory-benchmarks