-
Notifications
You must be signed in to change notification settings - Fork 130
Execute parent #5736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute parent #5736
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
| fn reduce_parent( | ||
| &self, | ||
| child: &DecimalBytePartsArray, | ||
| parent: &FilterArray, | ||
| _child_idx: usize, | ||
| ) -> VortexResult<Option<ArrayRef>> { | ||
| // TODO(ngates): we should benchmark whether to push-down filters with "lower parts". | ||
| // For now, we only push down if there are no lower parts. | ||
| if !child._lower_parts.is_empty() { | ||
| return Ok(None); | ||
| } | ||
|
|
||
| let new_msp = | ||
| FilterArray::new(child.msp.clone(), parent.filter_mask().clone()).into_array(); | ||
| let new_child = | ||
| DecimalBytePartsArray::try_new(new_msp, *child.decimal_dtype())?.into_array(); | ||
| Ok(Some(new_child)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we need this vs just decompressing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we implemented DBP as a scalar function, it would happen via unary filter pushdown. It's kind of important
CodSpeed Performance ReportMerging #5736 will degrade performances by 19.97%Comparing Summary
Benchmarks breakdown
Footnotes
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
No description provided.