Skip to content

validate object store response length #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onursatici merged 2 commits into from
Nov 6, 2025
Merged

validate object store response length #5219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fceb0f2
validate object store response length
onursatici Nov 6, 2025
4904c9d
Merge branch 'develop' into os/validate
onursatici Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion vortex-io/src/file/object_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use futures::stream::BoxStream;
use futures::{FutureExt, StreamExt};
use tracing::Instrument;
use vortex_buffer::ByteBufferMut;
use vortex_error::{VortexError, VortexResult};
use vortex_error::{VortexError, VortexResult, vortex_ensure};

use crate::file::IoRequest;
use crate::file::read::{CoalesceWindow, IntoReadSource, ReadSource, ReadSourceRef};
Expand Down Expand Up @@ -141,6 +141,15 @@ impl ReadSource for ObjectStoreIoSource {
while let Some(bytes) = byte_stream.next().await {
buffer.extend_from_slice(&bytes?);
}

vortex_ensure!(
buffer.len() == len,
"Object store stream returned {} bytes but expected {} bytes (range: {:?})",
buffer.len(),
len,
range
);

buffer
}
};
Expand Down
Loading