Skip to content

Fix: remove CMSProvider dataset for lance v2.1 #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connortsui20 wants to merge 1 commit into from
Closed

Fix: remove CMSProvider dataset for lance v2.1 #4934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bench-vortex/src/bin/compress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use bench_vortex::display::{DisplayFormat, print_measurements_json, render_table
use bench_vortex::downloadable_dataset::DownloadableDataset;
use bench_vortex::measurements::{CompressionTimingMeasurement, CustomUnitMeasurement};
use bench_vortex::public_bi::PBI_DATASETS;
use bench_vortex::public_bi::PBIDataset::{Arade, Bimbo, CMSprovider, Euro2016, Food, HashTags};
use bench_vortex::public_bi::PBIDataset::{Arade, Bimbo, Euro2016, Food, HashTags};
use bench_vortex::utils::new_tokio_runtime;
use bench_vortex::{Engine, Format, Target, setup_logging_and_tracing};
use clap::Parser;
Expand Down Expand Up @@ -106,7 +106,7 @@ fn compress(
&TaxiData as &dyn Dataset,
PBI_DATASETS.get(Arade),
PBI_DATASETS.get(Bimbo),
PBI_DATASETS.get(CMSprovider),
// PBI_DATASETS.get(CMSprovider), // This fails with Lance v2.1
// Corporations, // duckdb thinks ' is a quote character but its used as an apostrophe
// CityMaxCapita, // 11th column has F, M, and U but is inferred as boolean
PBI_DATASETS.get(Euro2016),
Expand Down
Loading