Skip to content

Fix: remove CMSProvider dataset for lance v2.1 #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
connortsui20 wants to merge 1 commit into from
Closed

Fix: remove CMSProvider dataset for lance v2.1 #4934

connortsui20 wants to merge 1 commit into from

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Oct 13, 2025 •
edited
Loading

Issue filed directly on lance: lance-format/lance#4943

@connortsui20
remove CMSProvider dataset for lance v2.1
e45f8ee 
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/fix A bug fix label Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (2b87ba1) to head (e45f8ee).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20
Copy link
Contributor Author

connortsui20 commented Oct 13, 2025

Instead we can just run Lance v2.0 for our compression benchmarks

@connortsui20 connortsui20 deleted the ct/lance-2.1 branch October 13, 2025 18:09
@connortsui20 connortsui20 mentioned this pull request Oct 13, 2025
Merged
connortsui20 added a commit that referenced this pull request Oct 13, 2025
@connortsui20
Fix: revert Lance v2.1->v2.0 for compression benchmark (#4936)
46e2538 
As per lance-format/lance#4943 and
#4934

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwwmanning lwwmanning Awaiting requested review from lwwmanning

@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

Assignees

No one assigned

Labels

changelog/fix A bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connortsui20