Fix predicate return #3553
Merged
Fix predicate return #3553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XXL
lowang-bh
force-pushed
the
fixPredicateReturn
branch
2 times, most recently
from
9d05134 to
c2210f3
Compare
lowang-bh
force-pushed
the
fixPredicateReturn
branch
from
c2210f3 to
1ff09a3
Compare
volcano-sh-bot
added
size/XL
Monokaix
reviewed
Jul 17, 2024
Monokaix
reviewed
Jul 17, 2024
Monokaix
reviewed
Jul 17, 2024
lowang-bh
force-pushed
the
fixPredicateReturn
branch
from
1ff09a3 to
df1bee8
Compare
|
When upgrade from 1.8/1.9 to 1.10 seems compatibility issue wil also occur: ) |
Currently, no body has reported the issue after release 1.8/1.9. So maybe they did't met this issue without self-developed plugins. |
googs1025
reviewed
Jul 19, 2024
googs1025
reviewed
Jul 19, 2024
lowang-bh
force-pushed
the
fixPredicateReturn
branch
2 times, most recently
from
1d9bfd9 to
bdfb40c
Compare
Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com> Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
lowang-bh
force-pushed
the
fixPredicateReturn
branch
from
746d036 to
2b02a38
Compare
lowang-bh
force-pushed
the
fixPredicateReturn
branch
from
0ad6030 to
4bc4e4b
Compare
william-wang
reviewed
Aug 1, 2024
william-wang
reviewed
Aug 1, 2024
Signed-off-by: lowang-bh <lhui_wang@163.com>
lowang-bh
force-pushed
the
fixPredicateReturn
branch
from
4bc4e4b to
2dff5d8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3086
Part-2 of filter out those nodes which are UnschedulableAndUnresolvable when preempting #3432
Please merge 3432 first.
pod messages examples