Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicate function retrun value is not compatiable with old plugins #3086

Closed
lowang-bh opened this issue Aug 29, 2023 · 4 comments · Fixed by #3553
Closed

Predicate function retrun value is not compatiable with old plugins #3086

lowang-bh opened this issue Aug 29, 2023 · 4 comments · Fixed by #3553
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lowang-bh
Copy link
Member

lowang-bh commented Aug 29, 2023

There are other plugins dynamically loaded to volcano. eg. huawei's acend gpu, https://gitee.com/ascend/ascend-for-volcano

What happened:

https://github.com/volcano-sh/volcano/blob/b95d0f15e0ff2af9a7c9ae9a037a4c4c9e7300aa/pkg/scheduler/api/types.go#L170C6-L170C17

// PredicateFn is the func declaration used to predicate node for task.
type PredicateFn func(*TaskInfo, *NodeInfo) ([]*Status, error)

npu plugin
https://gitee.com/ascend/ascend-for-volcano/blame/master/huawei_npu.go

	// if npu no meet the task require,the task will failed.so need to intercept in advance
	ssn.AddPredicateFn(tp.Name(), func(taskInfo *api.TaskInfo, nodeInfo *api.NodeInfo) error {
		return sHandler.NodePredicate(taskInfo, nodeInfo, ssn.Configurations)
	})

What you expected to happen:

Should be compatiable with other extender plugins

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Introduced by refact PR #2916

Environment:

  • Volcano Version: master
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@lowang-bh lowang-bh added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2023
@lowang-bh
Copy link
Member Author

/assign

@william-wang william-wang added this to the roadmap milestone Sep 8, 2023
@william-wang
Copy link
Member

Let's do this in v1.9

@lowang-bh
Copy link
Member Author

@Monokaix we need to fix it in new realease.

@lowang-bh
Copy link
Member Author

/assign @Monokaix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants