Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] optimize resource comparision functions for performance #2026

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Feb 17, 2022

Signed-off-by: huone1 huwanxing@huawei.com

fix: #2014

Signed-off-by: huone1 <huwanxing@huawei.com>
@hwdef hwdef changed the title optimize resource comparision functions for performance [cherry-pick] optimize resource comparision functions for performance Feb 17, 2022
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2022
@k82cn
Copy link
Member

k82cn commented Feb 17, 2022

That'll be great to have this feature in mainline firstly :)

@hwdef
Copy link
Member Author

hwdef commented Feb 17, 2022

That'll be great to have this feature in mainline firstly :)

Yes, the master branch already had this commit #1769

@k82cn
Copy link
Member

k82cn commented Feb 17, 2022

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@k82cn
Copy link
Member

k82cn commented Feb 17, 2022

@volcano-sh-bot volcano-sh-bot merged commit dad66d4 into volcano-sh:release-1.4 Feb 17, 2022
@hwdef hwdef deleted the c-p-1769 branch February 17, 2022 06:56
@hwdef
Copy link
Member Author

hwdef commented Feb 17, 2022

bwt, you can try this script: https://github.com/volcano-sh/volcano/blob/master/hack/cherry_pick_pull.sh .

Thanks!
I need this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants