optimize resource comparision functions for performance #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
huone1
force-pushed
the
opt-rescompare
branch
from
a579bbc to
df6b28d
Compare
volcano-sh-bot
added
size/L
shinytang6
reviewed
Oct 12, 2021
wpeng102
reviewed
Oct 18, 2021
huone1
force-pushed
the
opt-rescompare
branch
from
df6b28d to
88f91f6
Compare
huone1
force-pushed
the
opt-rescompare
branch
from
88f91f6 to
b6e9b8e
Compare
Signed-off-by: huone1 <huwanxing@huawei.com>
huone1
force-pushed
the
opt-rescompare
branch
from
b6e9b8e to
a930248
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huone1 huwanxing@huawei.com
when there are many node in cluster, the clone operation is time-consuming in resource comparision functions sush as LessEqual
the logic has some changes： just compare the left resource list