vdk-plugins: run tests on release of vdk-core - #1210
Merged
Conversation
antoniivanov
force-pushed
the
person/aivanov/vdk-plugin-tests
branch
from
October 4, 2022 14:28
78b357d to
a4906d6
Compare
murphp15
reviewed
Oct 4, 2022
antoniivanov
force-pushed
the
person/aivanov/vdk-plugin-tests
branch
5 times, most recently
from
October 4, 2022 20:44
d9ca92e to
8bdfa53
Compare
antoniivanov
marked this pull request as ready for review
October 5, 2022 08:17
Collaborator
|
Hey @tozka , |
Contributor
Author
vdk-lineage is explicitly said to be POC level yet. But I will add vdk-csv |
antoniivanov
force-pushed
the
person/aivanov/vdk-plugin-tests
branch
from
October 5, 2022 09:30
b862611 to
98c3a23
Compare
antoniivanov
enabled auto-merge (squash)
October 5, 2022 09:43
Collaborator
|
Thanks! |
dakodakov
approved these changes
Oct 5, 2022
Changes in vdk-core can break some plugins. We need some functionality that enables us to catch such regression quicker. The proposoed change is to introduce in .plugin-common.yml new generic "job" template `.build-plugin-on-vdk-core-release` which can be used by plugins CI. As it should not be necessary to run all plugin tests, we can select some more important Testing Done: CI Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Changes in vdk-core can break some plugins. We need some functionality that enables us to catch such regression quicker. The proposoed change is to introduce in .plugin-common.yml new generic "job" template `.build-plugin-on-vdk-core-release` which can be used by plugins CI. As it should not be necessary to run all plugin tests, we can select some more important Testing Done: Setup CI to trigger the enw job and verified it's using vdk-core dev version for the tests. Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-plugin-tests
branch
from
October 5, 2022 21:32
8a8d506 to
0f352e2
Compare
antoniivanov
disabled auto-merge
October 5, 2022 22:01
antoniivanov
enabled auto-merge (squash)
October 5, 2022 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in vdk-core can break some plugins. We need some functionality that enables us to catch such regression quicker.
The proposoed change is to introduce in .plugin-common.yml new generic "job" template
.build-plugin-on-vdk-core-releasewhich can be used by plugins CI.As it should not be necessary to run all plugin tests, we can select some more important
Testing Done: CI
Signed-off-by: Antoni Ivanov aivanov@vmware.com