Skip to content

Commit a4906d6

Browse files
committed
vdk-plugins: run tests on release of vdk-core
Changes in vdk-core can break some plugins. We need some functionality that enables us to catch such regression quicker. The proposoed change is to introduce in .plugin-common.yml new generic "job" template `.build-plugin-on-vdk-core-release` which can be used by plugins CI. As it should not be necessary to run all plugin tests, we can select some more important Testing Done: CI Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
1 parent 79ff8ae commit a4906d6

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

projects/vdk-plugins/.plugin-common.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
- cd projects/vdk-plugins/
1414
- pip install -U pip
1515
- pip install ./vdk-test-utils # TODO: REMOVE THIS AT SOME POINT
16+
- if -n "${USE_VDKCORE_DEV_VERSION}" ; then pip install -e ../projects/vdk-core; fi
1617
script:
1718
- echo "Build plugin $PLUGIN_NAME"
1819
- cd ./$PLUGIN_NAME || exit 1
@@ -28,6 +29,16 @@
2829
reports:
2930
junit: tests.xml
3031

32+
.build-plugin-on-vdk-core-release:
33+
variables:
34+
USE_VDKCORE_DEV_VERSION: "yes"
35+
extends: .build-plugin
36+
rules:
37+
- if: '$CI_COMMIT_BRANCH == "main" || $CI_PIPELINE_SOURCE == "external_pull_request_event"'
38+
changes:
39+
- "projects/vdk-core/*"
40+
- "projects/vdk-core/src/**/*"
41+
3142
.build-plugin-dind:
3243
image: docker:19.03.8
3344
services:

projects/vdk-plugins/vdk-impala/.plugin-ci.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,9 @@
44
image: "python:3.7"
55

66
.build-vdk-impala:
7-
image: docker:19.03.8
8-
services:
9-
- docker:19.03.8-dind
107
variables:
11-
DOCKER_HOST: tcp://localhost:2375
12-
DOCKER_DRIVER: overlay2
13-
DOCKER_TLS_CERTDIR: ""
148
PLUGIN_NAME: vdk-impala
15-
extends: .build-plugin
9+
extends: .build-plugin-dind
1610

1711
build-py37-vdk-impala:
1812
extends: .build-vdk-impala
@@ -33,6 +27,13 @@ build-py310-vdk-impala:
3327
image: "python:3.10"
3428

3529

30+
build-vdk-impala-on-vdk-core-release:
31+
variables:
32+
PLUGIN_NAME: quickstart-vdk
33+
extends: .build-plugin-on-vdk-core-release
34+
image: "python:3.9"
35+
36+
3637
release-vdk-impala:
3738
variables:
3839
PLUGIN_NAME: vdk-impala

0 commit comments

Comments
 (0)