Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Aggregation process methods (#158) #181

Merged
merged 1 commit into from
May 3, 2021

Conversation

srikartati
Copy link
Contributor

Delete the unrequired method of deleting record from
record map without the lock.
Add a method to get the flow updated time for flow given flow key

Pushing this to main. Based on the Antrea PR progress, I will add this to release-0.5.0 branch.

Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #181 (c04b688) into main (b11eef6) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   78.88%   78.92%   +0.03%     
==========================================
  Files          16       16              
  Lines        2008     2021      +13     
==========================================
+ Hits         1584     1595      +11     
- Misses        280      281       +1     
- Partials      144      145       +1     
Flag Coverage Δ
integration-tests 61.86% <0.00%> (-2.98%) ⬇️
unit-tests 78.36% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/intermediate/aggregate.go 74.77% <85.71%> (+0.39%) ⬆️

Copy link
Contributor

@zyiou zyiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a previously approved PR.

@srikartati srikartati merged commit 19760d7 into vmware:main May 3, 2021
@srikartati srikartati deleted the modify_agg_main branch May 3, 2021 23:16
zyiou pushed a commit to zyiou/go-ipfix that referenced this pull request May 13, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
zyiou pushed a commit that referenced this pull request May 13, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants