Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Aggregation process methods #158

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

srikartati
Copy link
Contributor

Delete the unrequired method of deleting record from record map without lock.
Add a method to get the flow updated time for the flow given flow key.

This is required for PR in Antrea: antrea-io/antrea#1949

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #158 (631a37d) into release-0.4.0 (dbfa3a0) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-0.4.0     #158      +/-   ##
=================================================
+ Coverage          78.53%   78.57%   +0.04%     
=================================================
  Files                 13       13              
  Lines               1812     1825      +13     
=================================================
+ Hits                1423     1434      +11     
- Misses               254      255       +1     
- Partials             135      136       +1     
Flag Coverage Δ
integration-tests 62.54% <0.00%> (-0.61%) ⬇️
unit-tests 77.47% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/intermediate/aggregate.go 74.77% <85.71%> (+0.39%) ⬆️

@srikartati
Copy link
Contributor Author

@zyiou Please get to this quickly when you have time. It is a small patch and an Antrea PR is dependent on this.

Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
Copy link
Contributor

@zyiou zyiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srikartati srikartati merged commit 5d063cd into vmware:release-0.4.0 Mar 30, 2021
@srikartati srikartati deleted the changes_agg_process branch March 30, 2021 08:53
srikartati added a commit to srikartati/go-ipfix that referenced this pull request Apr 15, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
srikartati added a commit that referenced this pull request Apr 15, 2021
srikartati added a commit that referenced this pull request Apr 15, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
srikartati added a commit that referenced this pull request Apr 15, 2021
This reverts commit 5d063cd.
This is done to have these commits to be part of v0.5.0 release instead of 0.4.x release
srikartati added a commit that referenced this pull request Apr 17, 2021
srikartati added a commit to srikartati/go-ipfix that referenced this pull request Apr 17, 2021
Reverting this commit 7c0a0ae.
Reason is the PR(antrea-io/antrea#1949) that depends on this commit
is not yet ready. And to move the tag of go-ipfix in Antrea for other
PRs this commit should be present in the latest release tags. Therefore,
reverting this.
srikartati added a commit that referenced this pull request Apr 19, 2021
Reverting this commit 7c0a0ae.
Reason is the PR(antrea-io/antrea#1949) that depends on this commit
is not yet ready. And to move the tag of go-ipfix in Antrea for other
PRs this commit should be present in the latest release tags. Therefore,
reverting this.
srikartati added a commit to srikartati/go-ipfix that referenced this pull request May 3, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
srikartati added a commit to srikartati/go-ipfix that referenced this pull request May 3, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
srikartati added a commit that referenced this pull request May 3, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
zyiou pushed a commit to zyiou/go-ipfix that referenced this pull request May 13, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
zyiou pushed a commit that referenced this pull request May 13, 2021
Delete the unrequired method of deleting record from
record map without lock.
Add a method to get the flow updated time for flow given flow key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants