Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DownloadRequest Stream function #7175

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Dec 5, 2023

Thank you for contributing to Velero!

Please add a summary of your change

  • Fix PR Linter part2 #7151 introduced context bug.
  • Refactor the DownloadRequest Stream function. Split it into two parts: GetDownloadURL and Download.
  • Refactor the context usage to replace the wait logic.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ba625) 61.80% compared to head (c8e76f4) 61.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7175   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files         261      261           
  Lines       27968    27968           
=======================================
  Hits        17286    17286           
  Misses       9465     9465           
  Partials     1217     1217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Clean the DownloadRequest Stream function.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet marked this pull request as ready for review December 5, 2023 05:42
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blackpiglet blackpiglet mentioned this pull request Dec 5, 2023
33 tasks
@Lyndon-Li Lyndon-Li merged commit 8d8d68d into vmware-tanzu:main Dec 6, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants