Enable more linters for Velero

[blackpiglet]

v1.12

• asasalint - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• asciicheck - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• bidichk - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• dogsled - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• durationcheck - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• errcheck - Enable errcheck linter and resolve found issues. #6208
• exportloopref - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• goprintffuncname - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• gosimple - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• govet - fix go vet warnings #6154
• importas - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• ineffassign - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• nakedret - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• revive - Enable linter revive and resolve found errors: part1 #6173 Enable linter revive and resolve found errors: part2 #6177
• staticcheck - Enable staticcheck and resolve found issues. #6183
• stylecheck - Enable stylecheck linter and resolve found issues. #6185
• unconvert - Enable more linters, and remove mal-functioned milestoned issue action. #6194
• usestdlibvars - Fix usestdlibvars and whitespace linters issues. #6162
• whitespace - Fix usestdlibvars and whitespace linters issues. #6162

v1.13

• containedctx: delay due to needing some significant changes to resolve.
• depguard: dependency guard check is not needed yet.
• dupword
• errchkjson
• gci: the linter requires deleting the blank lines in the import section of some files. It doesn't make sense to me.
• ginkgolinter
• gocritic
• godot: This linter checks whether comments end with a dot. Not that import to me.
• nilerr
• noctx
• nolintlint
• prealloc
• predeclared
• thelper

Describe the problem/challenge you have

Describe the solution you'd like

Anything else you would like to add:

Environment:

• Velero version (use velero version):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "The project would be better with this feature added"
• 👎 for "This feature will not enhance the project in a meaningful way"

[reasonerjt]

@blackpiglet
As discussed we certainly will make enhancements in the linter and static code check, please add more issues to specify what are planned.

[kaovilai]

Damn..

[blackpiglet]

Yeah. There is still a long road ahead.
But don't worry. Some linters require many changes already in progress, such as revive, staticcheck, and stylecheck, of course, also including govet. Thanks for your contribution.

And many linters don't require a lot of hassle. Even no change is needed.

[kaovilai]

@blackpiglet Try using task list format which makes it easier to navigate back to the epic
ie.

- [x] #739
- [ ] https://github.com/octo-org/octo-repo/issues/740

[blackpiglet]

@kaovilai Thanks for the suggestion.

[blackpiglet]

v1.12 related issues are all resolved.

[reasonerjt]

Will reusing this issue to track the work in v1.13

[blackpiglet]

After #7175 merging, v1.13's jobs are done for this task.

[blackpiglet]

#7175 is merged. Remove from the v1.13 milestone.