Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more linters, and remove mal-functioned milestoned issue action. #6194

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Apr 25, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #6194 (4f2ebb4) into main (a0b0b7c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #6194   +/-   ##
=======================================
  Coverage   41.29%   41.29%           
=======================================
  Files         251      251           
  Lines       23386    23386           
=======================================
  Hits         9658     9658           
  Misses      12970    12970           
  Partials      758      758           
Impacted Files Coverage Δ
pkg/cmd/server/server.go 5.16% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet force-pushed the linter_more branch 2 times, most recently from 2112263 to 64342ed Compare April 25, 2023 13:27
@blackpiglet blackpiglet marked this pull request as ready for review April 25, 2023 13:38
@github-actions github-actions bot requested review from sseago and ywk253100 April 25, 2023 13:38
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@blackpiglet blackpiglet merged commit a8a17d7 into vmware-tanzu:main Apr 26, 2023
@blackpiglet blackpiglet mentioned this pull request Jul 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants