Prefer conditional waiting over magic sleep #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
carlisia,
dsu-igeek,
jenting,
nrb and
zubron
github-actions
bot
added
has-changelog
Dependencies
ashish-amarnath
force-pushed
the
robust-e2e
branch
2 times, most recently
from
0819af0
to
2aaf9d3
Compare
github-actions
bot
removed
the
Dependencies
nrb
previously approved these changes
Mar 5, 2021
|
Partially addresses #3532 |
Closed
ashish-amarnath
added
P1 - Important
kind/release-blocker
carlisia
reviewed
Mar 9, 2021
zubron
suggested changes
Mar 9, 2021
There was a problem hiding this comment.
This is great, thank you @ashish-amarnath! I just have one request to also wait for the namespace deletion at the end of RunKibishiiTests.
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
force-pushed
the
robust-e2e
branch
from
2aaf9d3
to
d8c1347
Compare
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
force-pushed
the
robust-e2e
branch
from
d8c1347
to
09dfb86
Compare
zubron
approved these changes
Mar 9, 2021
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
* prefer conditional waiting over magic sleep Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * update go modules Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
* prefer conditional waiting over magic sleep Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * update go modules Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
* prefer conditional waiting over magic sleep Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * update go modules Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Amarnath ashisham@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.