Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky e2e tests #3532

Closed
ashish-amarnath opened this issue Mar 5, 2021 · 2 comments · Fixed by #3564
Closed

Flaky e2e tests #3532

ashish-amarnath opened this issue Mar 5, 2021 · 2 comments · Fixed by #3564
Assignees
Labels

Comments

@ashish-amarnath
Copy link
Member

What steps did you take and what happened:
Velero E2E tests have non-deterministic waits/sleep that can cause the tests to occasionally produce false negatives.
We should use conditional waiting instead of non-deterministic waits to obtain more consistent test results.

What did you expect to happen:

The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version):
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ashish-amarnath ashish-amarnath added the E2E Tests End to end test label Mar 5, 2021
@ashish-amarnath ashish-amarnath added this to the v1.6.0 milestone Mar 5, 2021
@ashish-amarnath ashish-amarnath changed the title Flaky e2e test. Flaky e2e tests Mar 5, 2021
@ashish-amarnath
Copy link
Member Author

PR #3527 addresses the flake in the kibishii_tests

@codegold79
Copy link
Contributor

@ashish-amarnath, PR #3564 that fixes the API group versions e2e tests is ready to review.

@nrb nrb removed this from the v1.6.0 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants