Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ID token lifetime configurable for OIDCClients #1914

Merged
merged 8 commits into from
Apr 25, 2024

Refactors for custom ID token lifetime based on PR feedback

57a07a4
Select commit
Loading
Failed to load commit list.
Merged

Make ID token lifetime configurable for OIDCClients #1914

Refactors for custom ID token lifetime based on PR feedback
57a07a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 25, 2024 in 1s

38.45% (-0.18%) compared to 5fe94c4

View this Pull Request on Codecov

38.45% (-0.18%) compared to 5fe94c4

Details

Codecov Report

Attention: Patch coverage is 86.51163% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 38.45%. Comparing base (5fe94c4) to head (57a07a4).

Files Patch % Lines
...derationdomain/idtokenlifespan/idtoken_lifespan.go 44.44% 10 Missing ⚠️
...upervisor/config/v1alpha1/zz_generated.deepcopy.go 56.25% 7 Missing ⚠️
internal/federationdomain/oidc/oidc.go 94.17% 6 Missing ⚠️
.../federationdomain/endpoints/token/token_handler.go 83.33% 2 Missing and 1 partial ⚠️
internal/testutil/oidcclient.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
- Coverage   38.63%   38.45%   -0.18%     
==========================================
  Files         349      350       +1     
  Lines       44511    44680     +169     
==========================================
- Hits        17196    17182      -14     
- Misses      26799    26983     +184     
+ Partials      516      515       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov