Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ID token lifetime configurable for OIDCClients #1914

Merged
merged 8 commits into from
Apr 25, 2024

Refactors for custom ID token lifetime based on PR feedback

57a07a4
Select commit
Loading
Failed to load commit list.
Merged

Make ID token lifetime configurable for OIDCClients #1914

Refactors for custom ID token lifetime based on PR feedback
57a07a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Apr 25, 2024 in 0s

86.51% of diff hit (target 38.63%)

View this Pull Request on Codecov

86.51% of diff hit (target 38.63%)

Annotations

Check warning on line 432 in generated/latest/apis/supervisor/config/v1alpha1/zz_generated.deepcopy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

generated/latest/apis/supervisor/config/v1alpha1/zz_generated.deepcopy.go#L426-L432

Added lines #L426 - L432 were not covered by tests

Check warning on line 100 in internal/federationdomain/endpoints/token/token_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/federationdomain/endpoints/token/token_handler.go#L99-L100

Added lines #L99 - L100 were not covered by tests

Check warning on line 26 in internal/federationdomain/idtokenlifespan/idtoken_lifespan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/federationdomain/idtokenlifespan/idtoken_lifespan.go#L22-L26

Added lines #L22 - L26 were not covered by tests

Check warning on line 35 in internal/federationdomain/idtokenlifespan/idtoken_lifespan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/federationdomain/idtokenlifespan/idtoken_lifespan.go#L31-L35

Added lines #L31 - L35 were not covered by tests

Check warning on line 278 in internal/federationdomain/oidc/oidc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/federationdomain/oidc/oidc.go#L275-L278

Added lines #L275 - L278 were not covered by tests

Check warning on line 449 in internal/federationdomain/oidc/oidc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/federationdomain/oidc/oidc.go#L448-L449

Added lines #L448 - L449 were not covered by tests

Check warning on line 61 in internal/testutil/oidcclient.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/testutil/oidcclient.go#L61

Added line #L61 was not covered by tests

Check warning on line 88 in internal/testutil/oidcclient.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/testutil/oidcclient.go#L88

Added line #L88 was not covered by tests

Check warning on line 106 in internal/testutil/oidcclient.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/testutil/oidcclient.go#L106

Added line #L106 was not covered by tests