Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the container name when fetching keys from kube cert agent pod #1682

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Sep 18, 2023

This PR is to address the issue described in #1681.

Release note:

Fix an error that can occur in the Concierge when the cluster has been configured to automatically inject sidecar containers into every pod, including the kube cert agent pod.

Avoid errors seen when the cluster has been configured to automatically
inject additional sidecar containers into every pod.
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1682 (c0e7a6e) into main (465a0c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         163      163           
  Lines       15757    15758    +1     
=======================================
+ Hits        12483    12484    +1     
  Misses       2959     2959           
  Partials      315      315           
Files Changed Coverage Δ
internal/controller/kubecertagent/kubecertagent.go 92.70% <100.00%> (ø)
...l/controller/kubecertagent/pod_command_executor.go 87.09% <100.00%> (+0.43%) ⬆️

@joshuatcasey joshuatcasey merged commit 62887a9 into main Sep 18, 2023
37 checks passed
@joshuatcasey joshuatcasey deleted the exec_with_container_name branch September 18, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants