Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/ignore injected sidecar containers in the kube cert agent pod #1681

Closed
cfryanr opened this issue Sep 18, 2023 · 0 comments
Closed

Support/ignore injected sidecar containers in the kube cert agent pod #1681

cfryanr opened this issue Sep 18, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request estimate/S Estimated effort/complexity/risk is small state/accepted All done!

Comments

@cfryanr
Copy link
Member

cfryanr commented Sep 18, 2023

Is your feature request related to a problem? Please describe.

When the Pinniped Concierge is used on a cluster which is configured to automatically inject sidecar containers into every Pod, then the Concierge controller which fetches keys from the kube cert agent Pod will fail to fetch the keys. This can result in an unusable installation of the Concierge.

The following error will be seen in the Concierge pod logs and on the status of the CredentialIssuer resource: could not exec into agent pod ... a container name must be specified for pod.

This was not seen previously because there is normally only one container deployed in the pod, unless the cluster is configured to automatically inject additional containers.

Describe the solution you'd like

The kube cert agent controller should specify the name of the container into which it wants to exec.

Are you considering submitting a PR for this feature?

Yes.

@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/backlog Prioritized for an upcoming iteration estimate/S Estimated effort/complexity/risk is small labels Sep 18, 2023
@pinniped-ci-bot pinniped-ci-bot added state/started Someone is working on it currently state/finished Code finished but not yet delivered state/delivered Ready for manual acceptance review and removed state/started Someone is working on it currently state/finished Code finished but not yet delivered labels Sep 18, 2023
@pinniped-ci-bot pinniped-ci-bot added state/accepted All done! and removed priority/backlog Prioritized for an upcoming iteration state/delivered Ready for manual acceptance review labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request estimate/S Estimated effort/complexity/risk is small state/accepted All done!
Projects
None yet
Development

No branches or pull requests

2 participants