Fix typo that prevented compiling with Go 1.19 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 75.39% 75.37% -0.02%
==========================================
Files 166 165 -1
Lines 14938 14936 -2
==========================================
- Hits 11262 11258 -4
- Misses 3383 3385 +2
Partials 293 293 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cfryanr
force-pushed
the
fix_typo_for_go1.19
branch
from
6f88544
to
a041295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in a file which is only compiled when using Go 1.19 or older.
Also remove the test for the test helper because it can't pass with Go 1.18 or older, and we don't really need it anyway.
Release note: